Fix JitPack builds #336
Merged
Fix JitPack builds #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default maven version on jitpack (3.6.1) fails to build commonmark-java with [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project commonmark-test-util: The plugin org.apache.maven.plugins:maven-compiler-plugin:3.13.0 requires Maven version 3.6.3
|
Thanks! From the docs it looks like if there's a maven wrapper it will use that version: https://jitpack.io/docs/BUILDING/#maven-projects Can you try adding maven wrapper instead of a custom configuration file? The wrapper might be useful in general. |
script generated with 'mvn wrapper:wrapper -Dmaven=3.6.3'
The wrapper script was generated via |
|
@robinst should this fix get merged, could you consider merging main into the footnotes branch(es) afterwards? That would allow testing out the new extensions before they are released. |
|
@zampino Thanks.
Done! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jitpack is a useful maven repository to develop against unreleased code hosted on github. The default maven version on jitpack (3.6.1) fails to build commonmark-java main with
These changes ensure the maven version used by jitpack is compatible with the current maven-compiler-plugin.
Jitpack builds stopped working as of 682bdb0, where the compiler plugin was last updated. I've also setup a mini repro in https://github.com/nextjournal/commonmark-java-jitpack-repro to test different versions against jitpack.