Switch to using the commons toolforge instance fully #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we used both the urbanecmbot instances and also the commons-android-app toolforge instance for the functioning of the app. The reality is that the commons-android-app instance itself had the ability to return all the data necessary for the app. Use the same to get all the data necessary for the app. Fixes #5462
Seems like a fallout of the change done in PR #5464 This hopefully should make the instrumentation tests resume.
nicolas-raoul
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
So far we used both the urbanecmbot instances and also the commons-android-app toolforge instance for the functioning of the app.
The reality is that the commons-android-app instance itself had the ability to return all the data necessary for the app. Use the same to get all the data necessary for the app.
Fixes #5462
Tests performed (required)
Tested prodDebug on OnePlus Nord with API level 32.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.