-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Enable Jetpack Compose #5520
Conversation
Is this about an existing bug or enhacement request? If yes would you mind providing the URL? Thanks! |
This is GitHub Dependabot. Dependabot automatically updates dependencies in GitHub Projects. Dependabot is built into GitHub. |
.github/dependabot.yml
Outdated
interval: "weekly" | ||
time: "03:00" | ||
|
||
- package-ecosystem: "maven" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this? Do we use Maven dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependabot updates Gradle dependencies and Maven packages in unison. For this to work, both must be declared. In fact, Gradle projects benefit the most from Dependabot. Everyone loves Dependabot.
I think it would be great to have it indeed. |
Understood |
@nicolas-raoul Task Complete: com.jackwharton.rxbinding could not be updated because of conflicts with io.reactivex.rxjava |
@nicolas-raoul AVD fails if JDK is updated but the current version of Android Studio uses JDK 17 and JBR 17 |
Nice, that's very promising! :-) Somehow the build fails with this error, any idea why? I am looking forward to testing the app with all of these updates. :-) |
@nicolas-raoul Thank you sir. I am fixing that error now. It is com.android.tools.build. I believe it is a build error in general and not the class itself. |
app/src/main/java/fr/free/nrw/commons/customselector/helper/OnSwipeTouchListener.kt: (42, 9): 'onFling' overrides nothing This line of code requires a manual fix. I will have to go through the code base and fix it. |
Wow, thanks a lot! :-) |
Accidental override: The following declarations have the same JVM signature (onFling(Landroid/view/MotionEvent;Landroid/view/MotionEvent;FF)Z):
'getMetrics(DisplayMetrics!): Unit' is deprecated. Deprecated in Java
'getter for defaultDisplay: Display!' is deprecated. Deprecated in Java |
@nicolas-raoul Fixed Accidental override: The following declarations have the same JVM signature (onFling(Landroid/view/MotionEvent;Landroid/view/MotionEvent;FF)Z): |
@nicolas-raoul Execution failed for task ':app:connectedBetaDebugAndroidTest'. |
@AbdhilahiRWabwire I believe this pull request would be a wonderful addition to the app. If some updates are creating issues, how about using ignore to leave these ones untouched for now? :-) |
@nicolas-raoul Running Dependency Audit |
Refactoring broken Kotlin files that use KAPT |
Thanks for all of the work! You can mark your pull request as "draft" until it is ready to review. :-) |
GitHub is not granting me permission to convert this Pull Request into a Draft. |
Some Views require Android API 33 to function but I have upgraded to Android API 34. I can fix the compatibility issue in the Views by refactoring. |
0758806
to
a81d48c
Compare
b5e4e22
to
16a1375
Compare
I see the Jetpack Compose Migration has begun. |
Jetpack Compose
This pull request audits the Gradle Build, Updates Dependencies, Migrates from KAPT to KSP, Enables Jetpack Compose and Enables Dependabot
dependabot.yml - Automated dependency updates built into GitHub
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
https://github.com/dependabot