Enhacement - Add Custom Image Selector FAB Option to Nearby #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Mar 27, 2024
There was a problem hiding this comment.
I get this crash with this branch, even after deleting the app's data:
APP_VERSION_NAME=4.2.1-debug-shashankiitbhu-custom_picker_5095
ANDROID_VERSION=14
PHONE_MODEL=Pixel 7 Pro
STACK_TRACE=java.lang.NullPointerException: Attempt to read from field 'android.widget.RelativeLayout fr.free.nrw.commons.databinding.FragmentNearbyParentBinding.rlContainerWlmMonthMessage' on a null object reference in method 'void fr.free.nrw.commons.nearby.fragments.NearbyParentFragment.onViewCreated(android.view.View, android.os.Bundle)'
at fr.free.nrw.commons.nearby.fragments.NearbyParentFragment.onViewCreated(NearbyParentFragment.java:330)
at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:2987)
at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:546)
at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2189)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2100)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2002)
at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3138)
at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:3072)
at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:251)
at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:502)
at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:201)
at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1645)
at android.app.Activity.performStart(Activity.java:8800)
at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3971)
at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:299)
at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:279)
at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:251)
at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:228)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:91)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2544)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loopOnce(Looper.java:232)
at android.os.Looper.loop(Looper.java:317)
at android.app.ActivityThread.main(ActivityThread.java:8501)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)
I am not getting this crash on branch main.
looking into this issue now |
|
@nicolas-raoul Fixed the crash, Please Review, thanks |
nicolas-raoul
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Working fine, uploaded this pic via Nearby using this branch:
https://commons.wikimedia.org/wiki/File:JR_East_Ebisu_Station.jpg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #4611
What changes did you make and why?
Added Custom Image Selector FAB Button and also Migrated NearbyParentFragment (In which I made these changes) to viewBinding
Tests performed (required)
Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.
Screenshots (for UI changes only)