Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests for updateDepictsProperty method #5795

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

rohit9625
Copy link
Contributor

@rohit9625 rohit9625 commented Aug 28, 2024

Description (required)

Fixes #5793 #5787

What changes did you make and why?

  • 1. testUpdateDepictsProperty:- Update the test to adapt to the updateDepictsProperty() method.
  • 2. Material Circular Progress Bar:- Replace the deprecated progress bar with the material one.
  • 3. SettingsActivity:- Remove to logic to manually initialize AppCompatDelegate because it was causing SettingsActivity to crash. The reason is adding a new dependency for Material Components, it uses the latest version of appCompat library.

Tests performed (required)

Tested ProdDebug on Samsung A14 with API level 34.

Screenshots (for UI changes only)

None

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing, upload working.
Thanks for the fixes! :-)

@nicolas-raoul nicolas-raoul merged commit 190135d into commons-app:main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test broken: WikidataEditServiceTest.testUpdateDepictsProperty
2 participants