Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Add vtk < 9.1 guard for vtkConfigure.h #1015

Closed
wants to merge 1 commit into from
Closed

COMP: Add vtk < 9.1 guard for vtkConfigure.h #1015

wants to merge 1 commit into from

Conversation

jadh4v
Copy link

@jadh4v jadh4v commented Dec 17, 2021

vtkConfigure.h has been deprecated and should only
be included if VTK version is < 9.1.

@jadh4v
COMP: Add vtk < 9.1 guard for vtkConfigure.h
46f01ea 
vtkConfigure.h has been deprecated and should only
be included if VTK version is < 9.1.
@jadh4v
Copy link
Author

jadh4v commented Dec 17, 2021

@jcfr take a look. This is needed for VTK-install to work. CTK was picking up the vtkConfigure.h from build directory even though VTK_LEGACY_REMOVE flag is set. Nevertheless, this header is not needed for vtk >= 9.1 as also confirmed by @mathstuf

@jcfr jcfr self-assigned this Dec 18, 2021
@jadh4v jadh4v mentioned this pull request Dec 22, 2021
Closed
@jcfr
Copy link
Member

jcfr commented Oct 24, 2022

Closing. This was superseded by 2e1c014 introduced through #1041

@jadh4v Thanks for contributing this change in the first place and my apology for not integrating it earlier and not giving proper credits in the latest pull request integrating a similar change.

@jcfr jcfr closed this Oct 24, 2022
@jadh4v
Copy link
Author

jadh4v commented Oct 27, 2022

No worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcfr jcfr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jadh4v @jcfr