ENH: Improve ctkLanguageComboBox #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this will also help for “English (US)” and “English (UK)” entries for “favorite color” vs “favourite colour” |
|
Yes, anybody can now provide translations for Slicer at https://crowdin.com/translate/slicer |
|
I'll stick with improving "English" as though it is "English (US)" as the Slicer default language. |
- Added `directories` property to specify multiple folders to scan for translation (*.qm) files (before that only one directory could be specified). - Added `countryFlagsVisible` property to display "country" name instead of country flag, because not all region is a country with a flag (e.g., Latin America). - Updated the logic that determines if country name (or flag) should be shown: if a translation of a language is only available for one region then the region name is not displayed. This avoids redundant item text such as "Hungarian (Hungary)" (it is just displayed as "Hungarian").
lassoan
force-pushed
the
languagebox-improvements
branch
from
244856a to
fe296ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
directoriesproperty to specify multiple folders to scan for translation (*.qm) files (before that only one directory could be specified).countryFlagsVisibleproperty to display "country" name instead of country flag, because not all region is a country with a flag (e.g., Latin America).Example of countryFlagsVisible=false: