-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add option on using system library #1020
Conversation
Solving issues like #911 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have been using CTK with VTK, ITK, etc. built outside of CTK for many years in 3D Slicer, as you can specify these variables as command-line arguments. So, adding the options is not necessary. However, it does not hurt to add these options. Maybe you could mark them as "advanced" to prevent cluttering the CMake GUI.
@lassoan Thanks for the hint, I think it's necessery to let advanced user to know that this option is available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it looks good to me.
If you squash the commits into one (and make sure the commit comment is valid) then it should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested on Windows10, MSVC16, VS2019.
There are some issues with DCMTK. When compling DCMTK related plugins, it is required to put compiled libraries in some project folder to be able to continue compling.