ENH: Set focus proxy on ctkPathLineEdit #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus proxy is set to the QLineEdit, which is a natural choice. This way the user of ctkPathLineEdit can set its focus policy and include in a tabbing order as though it's a single widget, without thinking about the underlying QWidgets internal to ctkPathLineEdit.
ebrahimebrahim
added a commit
to ebrahimebrahim/Slicer
that referenced
this pull request
Feb 21, 2022
After the CTK change introduced in commontk/CTK#1026 , we can get rid of the hacky solution to setting a reasonable ctkPathLineEdit focus proxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus proxy is set to the
QLineEdit, which is a natural choice.This way the user of
ctkPathLineEditcan set its focus policy andinclude in a tabbing order as though it's a single widget, without
thinking about the underlying QWidgets internal to
ctkPathLineEdit.Related discussion: Slicer/Slicer#6184 (comment)