COMP: Fix build against VTK > 9.1 explicitly including "vtkVersion.h" #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following Kitware/VTK@d933bb849 (vtkDeprecation: remove symbols deprecated in 9.1), the "vtkDeprecation.h" header (itself including "vtkVersionMacros.h" was removed from "vtkOpenGLRenderWindow.h". This commit fixes the related build errors by explicitly including "vtkVersion.h" and ensure that the macro like VTK_MAJOR_VERSION and VTK_MINOR_VERSION are defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Kitware/VTK@d933bb849 (vtkDeprecation: remove symbols deprecated
in 9.1), the "vtkDeprecation.h" header (itself including "vtkVersionMacros.h"
was removed from "vtkOpenGLRenderWindow.h". This commit fixes the related
build errors by explicitly including "vtkVersion.h" and ensure that
the macro like VTK_MAJOR_VERSION and VTK_MINOR_VERSION are defined.