Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix unnecessary warning in ctkVTKHistogram::resetRange() #1048

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

lassoan
Copy link
Member

@lassoan lassoan commented Oct 25, 2022

When the input image of ctkVTKHistogram was empty then resetRange() logged a warning. An empty image is a valid input (the histogram should be empty) and resetRange() operation is valid on the empty histogram, too. Therefore, it is not necessary to log a warning.

Removing the warning reduces noise during normal operation, which helps in detecting real problems.

When the input image of ctkVTKHistogram was empty then resetRange() logged a warning. An empty image is a valid input (the histogram should be empty) and resetRange() operation is valid on the empty histogram, too. Therefore, it is not necessary to log a warning.

Removing the warning reduces noise during normal operation, which helps in detecting real problems.
@lassoan lassoan merged commit 662e795 into master Oct 25, 2022
@lassoan lassoan deleted the fix-histogram-warning branch October 25, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants