BUG: Fix cursor position during auto-complete #1051
Conversation
When error messages were printed during auto-complete, the error messages got mixed up with the entered command. Fixed by inserting text into the correct position (this->textCursor() was called twice in ctkConsolePrivate::printString() and so the movePosition() call had no effect); also changed the code to use this->textCursor() consistently to get the cursor (sometimes the equivalent `QTextCursor c(this->document())` call was used) Also fixed output printing: always print pending messages before displaying the prompt. see Slicer/Slicer#6630
There was a problem hiding this comment.
Using the same example I provided in Slicer/Slicer#6630, this is definitely better! I can actually hit enter to autocomplete the field and have it be added to the correct line.
python-console-autocomplete-updated.mp4
The errors printed during typing are the same as in Slicer 5.0.3. In Slicer 5.0.3, they were just only seen in the log file as viewed in Help->Report A Bug, but now with the improvements to the python console we see these errors in the python console. So from a user standpoint I might be questioning if I'm doing something wrong now that these errors are more prominently displayed. In this specific autocomplete typed case, is there something that I'm doing wrong or is it just executing code prematurely in a manner that is invalid?
I suggest we revisit in a follow up PR, in the meantime, I will move forward with integration and update CTK. |
The error messages are reported if a property getter of a Python-wrapped Qt object reports an error (see for example a freshly created |
When error messages were printed during auto-complete, the error messages got mixed up with the entered command.
Fixed by inserting text into the correct position (this->textCursor() was called twice in ctkConsolePrivate::printString() and so the movePosition() call had no effect); also changed the code to use this->textCursor() consistently to get the cursor (sometimes the equivalent
QTextCursor c(this->document())call was used)Also fixed output printing: always print pending messages before displaying the prompt.
see Slicer/Slicer#6630