COMP: Fix DICOM/Core build ensuring Qt headers can always be included #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a regression introduced in c819ae7 (BUG: Mark translatable strings in DICOM/Core)
jcfr
referenced
this pull request
in Slicer/Slicer
Mar 22, 2023
Updated CTK to make more strings in DICOM browser translatable. Change log: Revision: ca5e014451e693b1f9e42250f5ce2ecfd0e7bd0f Author: Mouhamed DIOP <mouhamed.diop@esp.sn> Date: 2023-03-01 6:47:47 PM Message: BUG: Mark translatable strings in DICOM/Core see Slicer/SlicerLanguagePacks#17 see Slicer/SlicerLanguagePacks#12 Revision: 631acef7ccb35f3b965686700f9a74e234269057 Author: Mouhamed DIOP <mouhamed.diop@esp.sn> Date: 2023-03-01 4:05:20 PM Message: BUG: Mark translatable strings in DICOM/Widgets see Slicer/SlicerLanguagePacks#17 see Slicer/SlicerLanguagePacks#12 Revision: dd9c6754935b7635e1fb528a73646b463f093a01 Author: Steve Pieper <pieper@isomics.com> Date: 2023-03-15 9:10:21 AM Message: BUG: fix spelling error Thanks @mohamed Alalli BILAL for finding this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression introduced in c819ae7 (BUG: Mark translatable strings in DICOM/Core) through this pull request:
This issue happened because the build was originally tested on a platform having a case insensitive filesystem.
The expected header filename with
.hshould have beenqcoreapplication.h.For sake of consistency, let's always use the upper case convention without the
.h