Fix ctkCoreSettingsTest #1084
Merged
Fix ctkCoreSettingsTest #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cases specifying "<APPLICATION_HOME_DIR>" where relevant. Add missing unix cases and conditionally include platform specific cases. This is required because the function QDir::relativeFilePath() is computes the path base on "QDir::rootPath()" and "QDir::drives()" that are specific to each operating system. See https://github.com/qt/qtbase/blob/5.15/src/corelib/io/qdir.cpp#L844-L897 Also remove unused "d" variables from ctkCoreSettings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cases specifying
<APPLICATION_HOME_DIR>where relevant.Add missing unix cases and conditionally include platform specific cases. This is required because the function
QDir::relativeFilePath()is computes1 the path base onQDir::rootPath()andQDir::drives()that are specific to each operating system.Also remove unused
dvariables fromctkCoreSettings.Footnotes
https://github.com/qt/qtbase/blob/5.15/src/corelib/io/qdir.cpp#L844-L897 ↩