BUG: Fix merging display table fields containing commas #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a series description (or other field that is merged with mergeConcatenate) contained a comma, then it was concatenated even if it was the same. For example "first, second" was not found in the split fields because they were "first" and "second". Fixed by simply searching for the new value in the unsplit initial value. There might be issues with this too, for example if if there are series descriptions like "first", "second", and also "first, second", but in that case seeing only "first, second" is acceptable.
slicerbot
pushed a commit
to Slicer/SlicerGitSVNArchive
that referenced
this pull request
Aug 13, 2019
Re commontk/CTK#875 git-svn-id: http://svn.slicer.org/Slicer4/trunk@28436 3bd1e089-480b-0410-8dfb-8563597acbee
jcfr
pushed a commit
to NA-MIC/svn.slicer.org-Slicer4
that referenced
this pull request
Dec 22, 2022
Re commontk/CTK#875 git-svn-id: http://svn.slicer.org/Slicer4/trunk@28436 3bd1e089-480b-0410-8dfb-8563597acbee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a series description (or other field that is merged with mergeConcatenate) contained a comma, then it was concatenated even if it was the same. For example "first, second" was not found in the split fields because they were "first" and "second". Fixed by simply searching for the new value in the unsplit initial value.
There might be issues with this too, for example if if there are series descriptions like "first", "second", and also "first, second", but in that case seeing only "first, second" is acceptable.