BUG: typo in ctkDICOMDatabase #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issakomi
referenced
this pull request
Nov 6, 2019
Huge performance and usability improvement of DICOM browser. DICOM indexer: - Implemented background indexing (in worker thread): indexing may take several minutes and it is not desirable to block the entire application for this long time - Reduced indexing time by a factor of 3x (previously, inefficient database inserts, unnecessary queries, and table view updates slowed down the insertions) DICOM browser: - Removed popups from DICOM browser to not interfere with user workflow (questions, status updates, etc. are display in the browser layout) - Do not block the GUI while importing data sets, provide continuous, detailed update about indexing progress - Add separate displayed fields preset for DICOM query-retrieve database (this database is built without having access to the files, so less displayed fields can be computed) - Condensed table headers in horizontal mode (one row can hold all the search/filter fields instead of using one for each) - Set default sorting of columns (based on last insertion time, study date, and series number) - Added option to show DICOM metadata (right-click menu) - Added option to export datasets to file system (right-click menu) DICOM database: - Remove orphan empty directories after deleting files from the database - Emit signals when the database is opened or closed - Added display option for specifying column that is used for sorting by default - Improved displayed field update speed by about a factor of 100x (batch execution is very slow on sqlite and individual queries in a transaction should be used instead) DICOM query/retrieve: - Fixed crash when query/retrieve was used from Python (where database cannot be passed to the Q/R widget as a shared pointer)
|
Thank you @issakomi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S. 7f2f24a#r35829525
Thanks.