Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix font style in DICOM browser #916

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

lassoan
Copy link
Member

@lassoan lassoan commented Jun 1, 2020

With recent Qt versions, such as Qt-5.15, the special font set in the DICOM browser (in ctkDICOMTableView) does not get rendered correctly on Windows.
It is safer to remove this special font setting in CTK. It can be overridden set by the application anyway.

The only other place where font style was set in CTK was in ctkXnatTreeBrowserMainWindow. For consistency, the font setting has been removed from there, too.

Fixes Slicer/Slicer#4951

With recent Qt versions, such as Qt-5.15, the special font set in the DICOM browser (in ctkDICOMTableView) does not get rendered correctly on Windows.
It is safer to remove this special font setting in CTK. It can be overridden set by the application anyway.

The only other place where font style was set in CTK was in ctkXnatTreeBrowserMainWindow. For consistency, the font setting has been removed from there, too.

Fixes Slicer/Slicer#4951
@lassoan lassoan requested a review from pieper June 1, 2020 03:55
@pieper
Copy link
Member

pieper commented Jun 1, 2020

Yes, great, thanks.

@pieper pieper merged commit e9f845b into commontk:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect font in DICOM browser table since Qt update
2 participants