Ensure copyDirRecursively considers hidden directories and files #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassoan
reviewed
Nov 19, 2020
There was a problem hiding this comment.
It should be OK to change the default behavior but I would suggest to add a flag that allows reverting to the old behavior (i.e., filtering out hidden folders). For example, MacOS automatically creates junk folders (such as .DS_Store) that users may not want to include in the copy. Also update the documentation of the method in the header file.
|
Thanks for the review.
Great idea. I will do so. |
This commit adds an option to support previous behavior removed in commit 3af0ecf (BUG: Ensure copyDirRecursively considers hidden directories and files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix DCBIA-OrthoLab/ShapeVariationAnalyzer#54 (comment)