ENH: add command and history properties to ctkConsole #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the API allowed execution of commands but not setting the state of the command buffer to be executed when the user hit enter. Also the command history always started empty. This change adds read/write properties to fix this. Now the command buffer can be set, e.g. by a hot key or other custom code and it will be editable and the user can add more text, user the completer, etc. Also the command history can be controlled by the appication so that it can save and restore previous sessions as a convenience to the user.
lassoan
reviewed
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the API allowed execution of commands but not
setting the state of the command buffer to be executed when the
user hit enter.
Also the command history always started empty.
This change adds read/write properties to fix this.
Now the command buffer can be set, e.g. by a hot key or other
custom code and it will be editable and the user can add more text,
user the completer, etc.
Also the command history can be controlled by the appication so
that it can save and restore previous sessions as a convenience
to the user.