Fix dicom import from inside database folder and performance improvements #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieper
reviewed
Apr 8, 2021
pieper
requested changes
Apr 8, 2021
When data sets were imported from within the DICOM database folder without copying to the database, the full absolute path was stored in the database. However, when later the filename was used, it was determined to be a file within the database folder and therefore the filename was converted to relative path. Fixed the issue by always using relative paths if a data set is imported from within the database folder. This allows passing ownership of DICOM files to the database without making a copy (by moving the files to anywhere within the database folder and import from there without requesting a copy).
- Improve tag caching performance. There were unnecessary database queries due to looking up cache entries twice and looking up SOP instance UID for file. Also reduced some code duplication by factoring out reading of DICOM tags from files into a new helper function (readValueFromFile). - Add API to get first file or instance of a series. - Cache DatabaseDirectory to avoid recomputing it each time a file path is converted between relative and absolute.
jcfr
force-pushed
the
fix-dicom-import-from-inside-database-folder
branch
from
f758191 to
5be81f2
Compare
|
To streamline review, I moved the fix of line endings into its own commit. |
pieper
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue when retrieving values from tagcache fails when loading files that Slicer's DICOMwebBrowser retrieved (those files are imported from within the database folder, to avoid copying the files).
The performance and API improvements allow about 2x faster examining and loading of DICOM series that contain many instances.