BUG: Fix crash upon selecting files with DICOM browser import dialog #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #980 |
|
Yes, that looks like the fix. How about getting rid of all the |
pieper
approved these changes
Jul 14, 2021
|
Before merging I would suggest this gets tested on macOS as well for good measure. I only tested on Windows which is all I have available to me. |
|
I don't think this issue depends on the OS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #980.
Using my Windows machine and testing with 3D Slicer I was able to successfully import a file to the DICOM browser.
Previously it would crash upon selecting the "Import" button of the native dialog.
