Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python bindings for ctkCheckableHeaderView #985

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

kerim371
Copy link
Contributor

@kerim371 kerim371 commented Jul 25, 2021

ctkCheckableHeaderView used to be missing in python #793.
I modified CTK such that class constructor: ctkCheckableHeaderView(Qt::Orientation, QWidget *parent) is now accessible from python.
Also I moved two overloaded methods ctkCheckableHeaderView::checkState(...) to public Q_SLOTS so they are now also accessible from python.

@kerim371
Copy link
Contributor Author

I can see that CommitCheck doesn't bypass my commit. Do I need to fix that and if so where can see the rules for commits?

@jamesobutler
Copy link
Contributor

The CommitCheck wants an appropriate commit prefix. See https://github.com/Slicer/Slicer/blob/master/CONTRIBUTING.md#how-to-write-commit-messages-.

Also another check wants this branch up-to-date with the master branch. Your branch currently doesn’t have the 2 latest commits from master.

@jamesobutler
Copy link
Contributor

Note that ctkCheckableHeader stuff was also fixed as part of #796, but never integrated.

@kerim371 kerim371 force-pushed the master branch 3 times, most recently from c298529 to b8abc0e Compare July 26, 2021 00:16
@kerim371
Copy link
Contributor Author

@jamesobutler Hi,

Thank you for the tips, after few hours of struggling with git commit's messages I've finally corrected them

Note that ctkCheckableHeader stuff was also fixed as part of #796, but never integrated.

I guess my PR wont be redundant either #796 is accepted or stays abandoned

Co-authored-by: Andras Lasso <lasso@queensu.ca>
@lassoan lassoan force-pushed the master branch 2 times, most recently from b666de0 to 1ea40db Compare April 5, 2023 19:18
@lassoan lassoan merged commit fa1732f into commontk:master Apr 5, 2023
@lassoan
Copy link
Member

lassoan commented Apr 5, 2023

@kerim371 Thank you for your contribution. Sorry for taking this long to integrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants