ENH added AccessionNumber to Filters #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small change adds "AccessionNumber" support in DICOM queries
rbumm
changed the title
|
Thanks! I hope you are finding this code useful. Small nitpick, it should have had a colon in the commit message ("ENH:" instead of "ENH") but I merged it anyway since that's a very minor point and not worth going back and forth on. |
|
A squash and merge would have been a possibility for you to fix that up @pieper on merge |
|
Yes, I did try adding the colon during the squash step but it didn't stick. |
|
The change is in your merge commit. It appears you did a merge commit rather than a squash and merge. |
|
Yes, that sounds right. I'll keep an eye on that in the future. |
|
Thank you, Steve!
Am Fr., 30. Juli 2021 um 21:35 Uhr schrieb Steve Pieper <
***@***.***>:
… ***@***.**** approved this pull request.
LGTM 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#987 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEKMXPWNTTTIHNTAH2QIMSDT2L5IVANCNFSM5BI4F2KA>
.
|
|
Sorry for that. I will add the colons in the future.
Best regards Rudolf
Am Fr., 30. Juli 2021 um 21:57 Uhr schrieb James Butler <
***@***.***>:
… The change is in your merge commit. It appears you did a merge commit
rather than a squash and merge.
Merge pull request #987 from rbumm/patch-1
ENH: added AccessionNumber to Filters
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#987 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEKMXPRXA4W6PQLAOQGM2TDT2L73VANCNFSM5BI4F2KA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change adds "AccessionNumber" support in DICOM queries