Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: don't try to update null database #991

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

pieper
Copy link
Member

@pieper pieper commented Aug 17, 2021

Retrieve database is not created when there are no
studies selected leading to a crash.

Now there is no attempt to update a null database.

Slicer/Slicer#5244

Retrieve database is not created when there are no
studies selected leading to a crash.

Now there is no attempt to update a null database.

Slicer/Slicer#5244
Copy link
Contributor

@xriobe xriobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could exit earlier if d->dicomTableManager->currentStudiesSelection() is empty ?

@pieper
Copy link
Member Author

pieper commented Aug 18, 2021

We could exit earlier if d->dicomTableManager->currentStudiesSelection() is empty ?

That's what happens in effect. The for loop never gets entered so the operation completes instantly.

@xriobe
Copy link
Contributor

xriobe commented Aug 18, 2021

We could exit earlier if d->dicomTableManager->currentStudiesSelection() is empty ?

That's what happens in effect. The for loop never gets entered so the operation completes instantly.

I was thinking even at the beginning of the method, before the creation of the progress dialog and the ctkDICOMRetrieve, but that's fine like this too.

@pieper pieper merged commit 70ec660 into master Aug 25, 2021
@pieper pieper deleted the slicer-5244-retrieve-crash branch August 25, 2021 17:04
@pieper
Copy link
Member Author

pieper commented Aug 25, 2021

Thanks for the review. Since this is a small change I'm not going to update Slicer's superbuild yet. This will get included in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants