ENH: Impove DIMSE widget

[riep]

• Add collapsible button to hide DICOM server settings
• Only selected series are retrieved
  fixes Retrieve a selection of dicom from a PACS #993
  

[pieper]

I didn't have a chance to try it but it looks good to me - thanks for the contribution 👍

[lassoan]

It looks good, but since we still have the half of the window taken up by the "Search options" widget, the improvement is not that substantial.

It seems that the current layout is inspired by OsiriX:

This is not a good design (meaning of tabbed control for the input text is not unclear, number of displayable image modalities are limited, data sources always take up a lot of space, etc.). We don't need a complete rework of the GUI now (although it would be really nice), but it would be enough to:

• replace the date radiobuttons with a combobox
• replace the modality radiobuttons with a ctkCheckableComboBox
• replace the tabbed name/study/series/ID control by a simple combobox to select the search field and and the text input box side-by-side

I've checked how Weasis Query/Retrieve looks like and interestingly it is almost that same as the changes that I've outlined above:

[riep]

I do that

[riep]

I should init studyUID = currentStudyAndSeriesUIDPair->first to be clearer

[riep]

@lassoan one disadvantage of using a collapsible button for filters (as in the posted figure) is that you cannot combine multiple filters.

So, I propose to add a spin box to be able to add filters.
Increment of the spin box fold duplicates "filtername" combo box and "FilterPhrase" text box
Users will see all the filters in one shot

[lassoan]

You can easily combine multiple filters, you can have as many input lines as you want, you just need to show one at each time and hide the others. It is true that with a combobox you need two clicks to switch, so you may add a < and > buttons to go to the previous/next field.

[lassoan]

@riep I've updated this branch with a change that moves the search settings to the "Query" collapsible section and make the "Retrieve" section collapsible, too. The user can switch between these two sections (when one section is opened the other is closed automatically), so there is enough space for everything without the need to rework the search option widgets.

I've also updated tests that did not compile due to the changed API.

I've tested the retrieve of selected series and it worked well.

Please take a look, give it some testing and if you like it then I think we should merge this. Thanks for your contribution!

[riep]

Thanks Andras! I was very busy lately so this PR was delayed. I test it next Monday and let you know.

[riep]

This is nice. I have to double-check the code and check the code format. Is there a specific way to apply format in CTK?
Also, I thought that we could change the way the progress bar is updated. Do you think it would be OK to update the progress bar based on the number of series retrieved. Currently, the progress bar provides limited information on the remaining retrieve time.

[lassoan]

Is there a specific way to apply format in CTK?

I don't think there is a format specification file. However, the amount of modified code is so little that it should not be hard at all to fix up any formatting issues manually.

I thought that we could change the way the progress bar is updated. Do you think it would be OK to update the progress bar based on the number of series retrieved. Currently, the progress bar provides limited information on the remaining retrieve time.

Do you find the current progress bar too detailed or too high-level?
For long operations it is common to have double progress bar - overall progress (x out N series completed) and progress of the current step (x% of the current series is completed).

[riep]

ok, I would be nice to have a double progress bar. That could be part of another feature and PR. I do the code formatting and testing today.

[riep]

It looks good to me and should be ready to be merged.