Expose QSocketNotifier for Qt5 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently a bug in the generator (not yet identified) results in QSocketNotifier being only partially wrapped and new instances cannot be created from python and the following error instead: >>> qsn = qt.QSocketNotifier() Traceback (most recent call last): File "<console>", line 1, in <module> ValueError: No constructors available for QSocketNotifier This patch copies over the generated code from the Qt4.8 version and works around the issue until the generator issue can be identified.
|
I posted this to the PythonQt forum so we'll see if anyone knows a better solution. https://sourceforge.net/p/pythonqt/discussion/631392/thread/c989429c/ If we don't like the idea of patching the generated code, another workaround for me would be to add a qSlicerSocketNotifer in Slicer and make sure that is wrapped correctly. But fixing this PR seemed like the more generally useful solution. |
|
Thanks @pieper , this looks like a reasonable solution 👍 |
|
Also added a note to the README file. See f04eb5f |
pieper
added a commit
to commontk/CTK
that referenced
this pull request
Feb 8, 2018
jamesobutler
pushed a commit
to jamesobutler/PythonQt
that referenced
this pull request
Dec 12, 2023
* Remove spaces from environment variable setting because it only works without spaces
jcfr
pushed a commit
to jcfr/PythonQt
that referenced
this pull request
Jan 31, 2024
* Remove spaces from environment variable setting because it only works without spaces (cherry picked from commit MeVisLab/pythonqt@aa132d2)
jcfr
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Remove spaces from environment variable setting because it only works without spaces (cherry picked from commit MeVisLab/pythonqt@aa132d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently a bug in the generator (not yet identified)
results in QSocketNotifier being only partially
wrapped and new instances cannot be created from python
and the following error instead:
This patch copies over the generated code from the Qt4.8
version and works around the issue until the generator
issue can be identified.