-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12.0 imp commown self troubleshooting add links #220
12.0 imp commown self troubleshooting add links #220
Conversation
The former is used to group items together in a named section of their portal in a specific order. The latter can represent an ST page as before, but also an external link to a user documentation, like, e.g., Commown's discourse. It will make it possible to mix links with today's ST pages and order them all at will.
The methods should give the exact same results, although some tests had to be fixed as they were using a bad xml ref which was working by accident.
aef87d5
to
8aa41e4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 12.0 #220 +/- ##
==========================================
+ Coverage 90.22% 90.27% +0.04%
==========================================
Files 244 246 +2
Lines 8162 8203 +41
Branches 1051 1055 +4
==========================================
+ Hits 7364 7405 +41
Misses 628 628
Partials 170 170
☔ View full report in Codecov by Sentry. |
b65625a
to
2219da4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loganSIO possible de faire ces modifs et me renvoyer le fichier po correspondant ? Il faut relire les traductions, même si c'est fastidieux c'est important : je ne devrais pas trouver d'erreur idéalement.
Le fichier fr.po a été envoyé dans le ticket outils info associé. |
2219da4
to
4381060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loganSIO il en manque une, on tient le bon bout !
4381060
to
3dfd508
Compare
3dfd508
to
42d109e
Compare
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 1f123c0. Thanks a lot for contributing to commown. ❤️ |
No description provided.