Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 imp commown self troubleshooting add links #220

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

fcayre
Copy link
Collaborator

@fcayre fcayre commented Nov 9, 2023

No description provided.

The former is used to group items together in a named section of their
portal in a specific order.

The latter can represent an ST page as before, but also an external link
to a user documentation, like, e.g., Commown's discourse. It will make
it possible to mix links with today's ST pages and order them all at will.
The methods should give the exact same results, although some tests had
to be fixed as they were using a bad xml ref which was working by
accident.
@fcayre fcayre force-pushed the 12.0-imp-commown_self_troubleshooting-add-links branch from aef87d5 to 8aa41e4 Compare November 9, 2023 12:17
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (39bf8b8) 90.22% compared to head (42d109e) 90.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             12.0     #220      +/-   ##
==========================================
+ Coverage   90.22%   90.27%   +0.04%     
==========================================
  Files         244      246       +2     
  Lines        8162     8203      +41     
  Branches     1051     1055       +4     
==========================================
+ Hits         7364     7405      +41     
  Misses        628      628              
  Partials      170      170              
Files Coverage Δ
commown_self_troubleshooting/models/__init__.py 100.00% <100.00%> (ø)
commown_self_troubleshooting/models/res_partner.py 100.00% <100.00%> (ø)
...own_self_troubleshooting/models/troubleshooting.py 100.00% <100.00%> (ø)
commown_self_troubleshooting/tests/__init__.py 100.00% <100.00%> (ø)
...own_self_troubleshooting/tests/test_res_partner.py 100.00% <100.00%> (ø)
commown_self_troubleshooting/tests/test_tour.py 95.08% <100.00%> (+0.08%) ⬆️
...self_troubleshooting/tests/test_troubleshooting.py 100.00% <100.00%> (ø)
commown_self_troubleshooting/tests/test_pages.py 96.90% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcayre fcayre force-pushed the 12.0-imp-commown_self_troubleshooting-add-links branch 2 times, most recently from b65625a to 2219da4 Compare November 10, 2023 11:08
Copy link
Collaborator Author

@fcayre fcayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loganSIO possible de faire ces modifs et me renvoyer le fichier po correspondant ? Il faut relire les traductions, même si c'est fastidieux c'est important : je ne devrais pas trouver d'erreur idéalement.

commown_self_troubleshooting/i18n/fr.po Outdated Show resolved Hide resolved
commown_self_troubleshooting/i18n/fr.po Outdated Show resolved Hide resolved
commown_self_troubleshooting/i18n/fr.po Outdated Show resolved Hide resolved
commown_self_troubleshooting/i18n/fr.po Outdated Show resolved Hide resolved
commown_self_troubleshooting/i18n/fr.po Show resolved Hide resolved
commown_self_troubleshooting/i18n/fr.po Outdated Show resolved Hide resolved
commown_self_troubleshooting/i18n/fr.po Outdated Show resolved Hide resolved
commown_self_troubleshooting/i18n/fr.po Outdated Show resolved Hide resolved
@loganSIO
Copy link
Collaborator

@loganSIO possible de faire ces modifs et me renvoyer le fichier po correspondant ? Il faut relire les traductions, même si c'est fastidieux c'est important : je ne devrais pas trouver d'erreur idéalement.

Le fichier fr.po a été envoyé dans le ticket outils info associé.

@fcayre fcayre force-pushed the 12.0-imp-commown_self_troubleshooting-add-links branch from 2219da4 to 4381060 Compare November 10, 2023 11:51
Copy link
Collaborator Author

@fcayre fcayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loganSIO il en manque une, on tient le bon bout !

commown_self_troubleshooting/i18n/fr.po Show resolved Hide resolved
@fcayre fcayre force-pushed the 12.0-imp-commown_self_troubleshooting-add-links branch from 4381060 to 3dfd508 Compare November 10, 2023 14:48
@9184Lucky
Copy link
Collaborator

/ocabot merge patch

@github-grap-bot
Copy link
Collaborator

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-220-by-9184Lucky-bump-patch, awaiting test results.

@github-grap-bot
Copy link
Collaborator

Congratulations, your PR was merged at 1f123c0. Thanks a lot for contributing to commown. ❤️

@github-grap-bot github-grap-bot deleted the 12.0-imp-commown_self_troubleshooting-add-links branch November 14, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants