Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize a test which was crashing at end of month #229

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

fcayre
Copy link
Collaborator

@fcayre fcayre commented Nov 28, 2023

The test checks contract forecasts' behaviour, which depends on the date the test is run. The problem is that contract recurring next date field is not that predictable as its behaviour at end of month dates is shaky. We circumvent this problem by choosing a date slightly in the past and not close to the end of a month.

The test checks contract forecasts' behaviour, which depends on the date
the test is run. The problem is that contract recurring next date field
is not that predictable as its behaviour at end of month dates is shaky.
We circumvent this problem by choosing a date slightly in the past and
not close to the end of a month.
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (987ab2a) 90.47% compared to head (7e136a2) 90.45%.

Files Patch % Lines
rental_fees/tests/test_rental_fees_computation.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             12.0     #229      +/-   ##
==========================================
- Coverage   90.47%   90.45%   -0.03%     
==========================================
  Files         254      254              
  Lines        8408     8411       +3     
  Branches     1083     1084       +1     
==========================================
+ Hits         7607     7608       +1     
- Misses        632      633       +1     
- Partials      169      170       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcayre fcayre merged commit 139e192 into 12.0 Nov 28, 2023
2 of 4 checks passed
@github-grap-bot github-grap-bot deleted the 12.0-fix-rental_fees-unstable-test-result branch November 28, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants