Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 fix website sale b2b customer portal cannot validate sent quotations #330

Conversation

fcayre
Copy link
Collaborator

@fcayre fcayre commented Oct 24, 2024

No description provided.

... and add some documentation to avoid order variable related errors.
This is made by surrounding them both by a single transparent tag (<t>) that holds the condition.
…ent by us

Otherwise the user, although explicitely ask to validate the order, simply cannot.
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.39%. Comparing base (da7fcb9) to head (748dcb7).
Report is 6 commits behind head on 12.0.

Files with missing lines Patch % Lines
...te_sale_b2b/tests/test_payment_portal_templates.py 96.55% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             12.0     #330      +/-   ##
==========================================
+ Coverage   93.37%   93.39%   +0.02%     
==========================================
  Files         313      313              
  Lines       10951    11036      +85     
  Branches     1356     1361       +5     
==========================================
+ Hits        10225    10307      +82     
- Misses        532      534       +2     
- Partials      194      195       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcayre fcayre force-pushed the 12.0-fix-website_sale_b2b-customer-portal-cannot-validate-sent-quotations branch from 028a1ee to 748dcb7 Compare October 25, 2024 07:33
@fcayre
Copy link
Collaborator Author

fcayre commented Oct 25, 2024

/ocabot merge patch

@github-grap-bot
Copy link
Collaborator

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-330-by-fcayre-bump-patch, awaiting test results.

@github-grap-bot github-grap-bot merged commit 0376418 into 12.0 Oct 25, 2024
2 checks passed
@github-grap-bot
Copy link
Collaborator

Congratulations, your PR was merged at f005c52. Thanks a lot for contributing to commown. ❤️

@github-grap-bot github-grap-bot deleted the 12.0-fix-website_sale_b2b-customer-portal-cannot-validate-sent-quotations branch October 25, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants