Fixing compilation with field marked having FixedValue.

commschamp · Dec 8, 2024 · 55711c3 · 55711c3
1 parent f000117
commit 55711c3
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 2 deletions.
diff --git a/lib/include/cc_tools_qt/details/ToolsIntFieldImpl.h b/lib/include/cc_tools_qt/details/ToolsIntFieldImpl.h
@@ -144,7 +144,14 @@ class ToolsIntFieldImpl : public ToolsNumericFieldImpl<cc_tools_qt::field::Tools
 
     virtual void setDisplayValueImpl(UnderlyingType value) override
     {
-        Base::field().setDisplayValue(value);
+        using Tag = 
+            std::conditional_t<
+                Field::hasFixedValue(),
+                NoFeatureTag,
+                HasFeatureTag
+            >;
+
+        setDisplayValueInternal(value, Tag());
     }    
 
 private:
@@ -208,7 +215,19 @@ class ToolsIntFieldImpl : public ToolsNumericFieldImpl<cc_tools_qt::field::Tools
         [[maybe_unused]] static constexpr bool Must_not_be_called = false;
         assert(Must_not_be_called);
         return 0.0;
+    }    
+
+    void setDisplayValueInternal(UnderlyingType value, HasFeatureTag)
+    {
+        Base::field().setDisplayValue(value);
+    }   
+
+    void setDisplayValueInternal([[maybe_unused]] UnderlyingType value, NoFeatureTag)
+    {
+        [[maybe_unused]] static constexpr bool Must_not_be_called = false;
+        assert(Must_not_be_called);
     }      
+
 };
 
 template <typename TField>

diff --git a/lib/include/cc_tools_qt/details/ToolsUnsignedLongFieldImpl.h b/lib/include/cc_tools_qt/details/ToolsUnsignedLongFieldImpl.h
@@ -132,7 +132,14 @@ class ToolsUnsignedLongFieldImpl : public ToolsNumericFieldImpl<cc_tools_qt::fie
 
     virtual void setDisplayValueImpl(UnderlyingType value) override
     {
-        Base::field().setDisplayValue(value);
+        using Tag = 
+            std::conditional_t<
+                Field::hasFixedValue(),
+                NoFeatureTag,
+                HasFeatureTag
+            >;
+
+        setDisplayValueInternal(value, Tag());        
     }       
 
 private:
@@ -172,6 +179,17 @@ class ToolsUnsignedLongFieldImpl : public ToolsNumericFieldImpl<cc_tools_qt::fie
 
         return result;
     }
+
+    void setDisplayValueInternal(UnderlyingType value, HasFeatureTag)
+    {
+        Base::field().setDisplayValue(value);
+    }   
+
+    void setDisplayValueInternal([[maybe_unused]] UnderlyingType value, NoFeatureTag)
+    {
+        [[maybe_unused]] static constexpr bool Must_not_be_called = false;
+        assert(Must_not_be_called);
+    }     
 };
 
 template <typename TField>