This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
compare updates #212
Merged
compare updates #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added unique keys. updated returned object to include both added and removed rows. added Value Error if user passes unique keys and not columns or if unique keys contains a value not in columns
This was
linked to
issues
Dec 23, 2022
If unique_keys not in user specified columns then add them instead of error. Reduce complexity If unique_keys do not produce a Unique hash then error. With out this then the hash would overwrite values and would be missing data. Allow strings for columns_ignore and unique_keys to specify a single column. (i.e. `unique_keys='sn'`)
…and-removed_update Added IGNORE_COLUMNS variable If unique_keys not in user specified columns then add them instead of error. Reduce complexity If unique_keys do not produce a Unique hash then error. With out this then the hash would overwrite values and would be missing data. Allow strings for columns_ignore and unique_keys to specify a single column. (i.e. unique_keys='sn')
…oved' into 210-compare-return-add-and-removed
ghost
closed this
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added unique keys.
updated returned object to include both added and removed rows. added Value Error if user passes unique keys and not columns or if unique keys contains a value not in columns