Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script: LubeLogger #574

Merged
merged 36 commits into from
Nov 29, 2024
Merged

Conversation

quantumryuu
Copy link
Contributor

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Created install scripts for Lubelogger

Fixes # (issue)
#48
Project board

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

jq is needed to add some keys in the appsettings.json of lubelogger else it only work at http://localhost:5000

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@quantumryuu quantumryuu requested a review from a team as a code owner November 28, 2024 22:38
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Nov 28, 2024
@quantumryuu quantumryuu changed the title LubeLogger New Script: LubeLogger Nov 28, 2024
Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a few mini adjustments. But so far it looks good.

2 themes however:

  1. are the resources really sufficient? 500 MB is not really much.

  2. are there default access data? I have only tested briefly, not yet extensively.

@quantumryuu
Copy link
Contributor Author

Hello @MickLesk, about the resources, it's quite lightweight. Did some tests yesterday before the PR and seemed fine.
What do you mean by default access data? Like an user? If yes, then there is no user/login form

@MickLesk
Copy link
Member

Hello @MickLesk, about the resources, it's quite lightweight. Did some tests yesterday before the PR and seemed fine.
What do you mean by default access data? Like an user? If yes, then there is no user/login form

Allright. See it after my live Test Later ^^

@MickLesk MickLesk merged commit b328eed into community-scripts:main Nov 29, 2024
1 check passed
@quantumryuu quantumryuu deleted the LubeLogger branch November 29, 2024 23:15
@quantumryuu quantumryuu restored the LubeLogger branch November 29, 2024 23:19
@Banjer
Copy link

Banjer commented Nov 30, 2024

Thanks for adding this, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants