-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Script: LubeLogger #574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a few mini adjustments. But so far it looks good.
2 themes however:
-
are the resources really sufficient? 500 MB is not really much.
-
are there default access data? I have only tested briefly, not yet extensively.
Hello @MickLesk, about the resources, it's quite lightweight. Did some tests yesterday before the PR and seemed fine. |
Allright. See it after my live Test Later ^^ |
Thanks for adding this, much appreciated! |
Note
We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.
Description
Created install scripts for Lubelogger
Fixes # (issue)
#48
Project board
Type of change
Please check the relevant option(s):
Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:
Additional Information (optional)
jq is needed to add some keys in the appsettings.json of lubelogger else it only work at http://localhost:5000
Related Pull Requests / Discussions
If there are other pull requests or discussions related to this change, please link them here: