Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "This user is missing the User's ID, preventing the EasyCLA check" message #3847

Open
jarias-lfx opened this issue Mar 9, 2023 · 7 comments
Labels
bug Something isn't working CommunityReported

Comments

@jarias-lfx
Copy link

Summary

Please update the message and up for suggestions:

From:

The commit ([xxxxxx](https://github.com/xyz)). This user is missing the User's ID, preventing the EasyCLA check. [Consult GitHub Help](https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user) to resolve.For further assistance with EasyCLA, [please submit a support request ticket](https://jira.linuxfoundation.org/servicedesk/customer/portal/4).

To:

The commit ([xxxxxx](https://github.com/xyz)) is not linked to the GitHub account, preventing the EasyCLA check. [Consult Article Help](https://confluence.linuxfoundation.org/pages/viewpage.action?pageId=86641302) to resolve. For further assistance with EasyCLA, [please submit a support request ticket (https://jira.linuxfoundation.org/servicedesk/customer/portal/4).

Note the comment and the URL changing.

Background

When a PR is opened and one of the commits is not linked to the contributor's GitHub account. EasyCLA comment updates the PR with:

The commit [xxxxxxx]. This user is missing the User's ID, preventing the EasyCLA check. [Consult GitHub Help] to resolve.For further assistance with EasyCLA, [please submit a support request ticket]

It seems the message is confusing the contributors on how to resolve the issue. Hence requesting an update.

@jarias-lfx jarias-lfx added the bug Something isn't working label Mar 9, 2023
@justinabrahms
Copy link

Change to the new text:

The email address for the commit (xxxxxx) is not linked to the GitHub account [...]

@shyam-goshike
Copy link

To reproduce the issue, refer #3378

@jarias-lfx
Copy link
Author

jarias-lfx commented Apr 4, 2023

Adding the full comment:

The email address for the commit (xxxxxx) is not linked to the GitHub account, preventing the EasyCLA check. Consult Article Help and GitHub Help to resolve. For further assistance with EasyCLA, please submit a support request ticket.

@nickmango
Copy link
Collaborator

@jarias-lfx would this need to be updated ?

@nickmango
Copy link
Collaborator

This was updated as per the latest suggestion by @jarias-lfx .

@thakurveerendras
Copy link
Contributor

As discussed the missing Id case message is updated to below

❌ The email address for the commit (sun-test-org/repo1@ccc4463) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

Refer to the screenshot
image

@thakurveerendras
Copy link
Contributor

Verified issue on prod

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CommunityReported
Projects
None yet
Development

No branches or pull requests

6 participants