-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain missing email issue in error message #3867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kit1980 Thank you for your PR. We settled on the message specified in the last comment on this issue. #3847 to specify the missing GitHub ID. We also thought it best not to add a solution into the message text, since many times the reverse is true (needing to update the git config file to the correct email.) WDYT about changing your commit to the message in that comment?
The message from #3847 is definitely better then the current one in main. My concern is that people will not realize that they used a different email and still will not be able to resolve the issue themselves. And I understand the hesitation to add a solution into the message text, although in my experience helping multiple people with this issue in the PyTorch repo, in all but one case the desired solution was to add the email to the GitHub profile. |
@kit1980 Yes I think the .patch mention is a good idea. How about the following?: The email address for the commit (xxxxxx) is not linked to the GitHub account, preventing the EasyCLA check. Consult Article Help and GitHub Help to resolve. (To view the commit email address, add |
Hi @kit1980 would you like to amend your commit to the above and resubmit? |
@WillsonHG updated, please take a look. |
I'll rebase and sign the DCO if the change looks good. |
Signed-off-by: Sergii Dymchenko <sdym@fb.com>
Signed-off-by: Sergii Dymchenko <sdym@fb.com>
Signed-off-by: Sergii Dymchenko <sdym@fb.com>
Rebased and force-pushed to fix DCO. |
Thanks @kit1980 for your contribution, Refer testing details
Refer missing email error message :
|
Fixes are properly deployed on production , Refer PR CLATestOrg/VulDetect1#33 |
The current error message is not very clear and we've had multiple users in the PyTorch repo having problems with resolving this.