Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain missing email issue in error message #3867

Merged
merged 3 commits into from
May 3, 2023

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Mar 21, 2023

The current error message is not very clear and we've had multiple users in the PyTorch repo having problems with resolving this.

Copy link
Member

@WillsonHG WillsonHG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kit1980 Thank you for your PR. We settled on the message specified in the last comment on this issue. #3847 to specify the missing GitHub ID. We also thought it best not to add a solution into the message text, since many times the reverse is true (needing to update the git config file to the correct email.) WDYT about changing your commit to the message in that comment?

@kit1980
Copy link
Contributor Author

kit1980 commented Apr 8, 2023

Thank you for your PR. We settled on the message specified in the last comment on this issue. #3847 to specify the missing GitHub ID. We also thought it best not to add a solution into the message text, since many times the reverse is true (needing to update the git config file to the correct email.) WDYT about changing your commit to the message in that comment?

The message from #3847 is definitely better then the current one in main.

My concern is that people will not realize that they used a different email and still will not be able to resolve the issue themselves.
Maybe still mention the .patch page so they quickly see the exact email address used?

And I understand the hesitation to add a solution into the message text, although in my experience helping multiple people with this issue in the PyTorch repo, in all but one case the desired solution was to add the email to the GitHub profile.

@WillsonHG
Copy link
Member

WillsonHG commented Apr 12, 2023

@kit1980 Yes I think the .patch mention is a good idea. How about the following?:

The email address for the commit (xxxxxx) is not linked to the GitHub account, preventing the EasyCLA check. Consult Article Help and GitHub Help to resolve. (To view the commit email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

@WillsonHG
Copy link
Member

Hi @kit1980 would you like to amend your commit to the above and resubmit?

@kit1980
Copy link
Contributor Author

kit1980 commented Apr 21, 2023

Hi @kit1980 would you like to amend your commit to the above and resubmit?

@WillsonHG updated, please take a look.

@kit1980
Copy link
Contributor Author

kit1980 commented Apr 23, 2023

I'll rebase and sign the DCO if the change looks good.

@WillsonHG WillsonHG requested review from thakurveerendras and removed request for jarias-lfx May 1, 2023 15:17
Signed-off-by: Sergii Dymchenko <sdym@fb.com>
Signed-off-by: Sergii Dymchenko <sdym@fb.com>
Signed-off-by: Sergii Dymchenko <sdym@fb.com>
@kit1980
Copy link
Contributor Author

kit1980 commented May 1, 2023

Rebased and force-pushed to fix DCO.

@kit1980 kit1980 temporarily deployed to dev May 3, 2023 09:37 — with GitHub Actions Inactive
@kit1980 kit1980 temporarily deployed to dev May 3, 2023 09:37 — with GitHub Actions Inactive
@kit1980 kit1980 temporarily deployed to dev May 3, 2023 09:37 — with GitHub Actions Inactive
@nickmango nickmango merged commit 031ed0d into communitybridge:main May 3, 2023
@thakurveerendras
Copy link
Contributor

Thanks @kit1980 for your contribution,
Verified issue on Dev environment & found that above changes are proper & accepted by @mlehotskylf , @jarias-lfx , @WillsonHG

Refer testing details

  1. Link added on commit are proper & redirecting user to correct page
  1. MISSING ID ON COMMIT & NOT COVERED cla boat appears on same commit .
  2. Refer PR : test sun-test-org/repo1#69

Refer missing email error message :

❌ The email address for the commit (sun-test-org/repo1@2d6eeec) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

image

@kit1980 kit1980 deleted the patch-1 branch May 9, 2023 22:04
@thakurveerendras
Copy link
Contributor

Fixes are properly deployed on production , Refer PR CLATestOrg/VulDetect1#33
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants