Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerrit Onboarding #4358

Open
nickmango opened this issue Jun 12, 2024 · 2 comments
Open

Gerrit Onboarding #4358

nickmango opened this issue Jun 12, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request ldap

Comments

@nickmango
Copy link
Collaborator

Summary

Following the decommissioning of the LDAP group concept, the existing onboarding and the sign flow need to be updated to remove handling LDAP related activities

User Story

  • As a project manager, I want to be able to add gerrit instance without the LDAP group IDs (ICLA & CCLA Ids) that are required on PCC, such that there is no dependency on the LDAP feature

Acceptance Criteria

  1. Onboarding of a new gerrit instance should complete without the need for ICLA & CCLA group ids
  2. The Gerrit URL should be captured in the easyCLA db
@nickmango nickmango added the enhancement New feature or request label Jun 12, 2024
@nickmango nickmango self-assigned this Jun 12, 2024
nickmango added a commit to nickmango/easycla that referenced this issue Jun 17, 2024
- Removed LDAP group endpoints (icla,ecla)
- Updated gerrit onboarding API input with no icla &&& ccla group IDs
- Updated signed handlers to remove ldap group additions on signing
- Updated approval list handling of gerrit users (TODO - update a new way of handling users)

Signed-off-by: Harold Wanyama <hwanyama@contractor.linuxfoundation.org>
nickmango added a commit that referenced this issue Jun 17, 2024
@nickmango
Copy link
Collaborator Author

@thakurveerendras kindly verify.. This can be done using the gerrit add API https://api-gw.dev.platform.linuxfoundation.org/cla-service/v4/api-docs#tag/gerrits/operation/addGerrit whereby the groupIdccla and groupIdIcla are not required

@thakurveerendras
Copy link
Contributor

Tested on the dev site & found that AddGerrit API is properly implemented & it required only gerritUrl & gerritName parameter

{
"dateCreated": "2024-06-21T13:40:03Z",
"dateModified": "2024-06-21T13:40:03Z",
"gerritId": "2718a1e8-72af-4695-a073-b208a73353c4",
"gerritName": "ONAP",
"gerritUrl": "https://gerrit.onap.org",
"projectId": "01af041c-fa69-4052-a23c-fb8c1d3bef24",
"projectSFID": "a09P000000DsCE5IAN",
"version": "v2"
}

image

image

nickmango added a commit to nickmango/easycla that referenced this issue Jul 4, 2024
nickmango added a commit that referenced this issue Jul 4, 2024
Revert "[#4358,#4359] Feature/LDAP Decommissioning"
nickmango added a commit to nickmango/easycla that referenced this issue Jul 9, 2024
nickmango added a commit that referenced this issue Jul 9, 2024
Revert "Revert "[#4358,#4359] Feature/LDAP Decommissioning""
nickmango added a commit to nickmango/easycla that referenced this issue Jul 11, 2024
…eature/LDAP Decommissioning"""

This reverts commit 558ac26.
nickmango added a commit that referenced this issue Jul 11, 2024
Revert "Revert "Revert "[#4358,#4359] Feature/LDAP Decommissioning"""
nickmango added a commit to nickmango/easycla that referenced this issue Jul 16, 2024
nickmango added a commit that referenced this issue Jul 16, 2024
Revert "Revert "Revert "Revert "[#4358,#4359] Feature/LDAP Decommiss"""
nickmango added a commit to nickmango/easycla that referenced this issue Jul 17, 2024
nickmango added a commit that referenced this issue Jul 17, 2024
Revert "Revert "Revert "Revert "Revert "[#4358,#4359] Feature/LDAP"
nickmango added a commit to nickmango/easycla that referenced this issue Jul 18, 2024
nickmango added a commit that referenced this issue Jul 18, 2024
Revert "[#4358,#4359] Feature/LDAP Decommissioning"
nickmango added a commit to nickmango/easycla that referenced this issue Jul 30, 2024
nickmango added a commit that referenced this issue Jul 30, 2024
Revert "Revert "[#4358,#4359] Feature/LDAP Decommissioning""
nickmango added a commit to nickmango/easycla that referenced this issue Jul 30, 2024
…DAP Decommissioning""

This reverts commit e6515cf.

Signed-off-by: Harold Wanyama <hwanyama@contractor.linuxfoundation.org>
nickmango added a commit to nickmango/easycla that referenced this issue Aug 2, 2024
…eature/LDAP Decommissioning"""

This reverts commit 732488e.
nickmango added a commit that referenced this issue Aug 2, 2024
Revert "Revert "Revert "[#4358,#4359] Feature/LDAP Decommissioning"""
nickmango added a commit to nickmango/easycla that referenced this issue Aug 13, 2024
nickmango added a commit to nickmango/easycla that referenced this issue Aug 13, 2024
…#4359] Feature/LDAP Decommissioning""""

This reverts commit 4d37c4d.

Signed-off-by: Harold Wanyama <hwanyama@contractor.linuxfoundation.org>
nickmango added a commit that referenced this issue Aug 13, 2024
Revert "Revert "Revert "Revert "[#4358,#4359] Feature/LDAP Decommissi…
nickmango added a commit to nickmango/easycla that referenced this issue Aug 21, 2024
nickmango added a commit to nickmango/easycla that referenced this issue Aug 22, 2024
nickmango added a commit to nickmango/easycla that referenced this issue Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ldap
Projects
None yet
Development

No branches or pull requests

3 participants