Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test_type to TestDesc to compile on nightly rust #19

Merged
merged 10 commits into from
Nov 4, 2019

Conversation

cormacrelf
Copy link
Contributor

@cormacrelf cormacrelf commented Oct 18, 2019

Not sure if this should be more complicated, e.g.:

  • use if_rust_version to do what the unimplemented cfgs would do and
    enable test_type for those 6-day-old nightlies
  • add macro syntax for changing the test type? (probably not necessary)
  • update docs to reflect {usability with stable rust} not being itself stable?

Also obviously this is going to fail most tests

@cormacrelf cormacrelf changed the title add test_type to TestDesc to compile on nightly rust, fixes #18 add test_type to TestDesc to compile on nightly rust Oct 18, 2019
src/runner.rs Outdated Show resolved Hide resolved
@cormacrelf
Copy link
Contributor Author

Ok, so:

  • the new parse_opts location also needs papering over in the post_v139 feature
  • CI needs the feature enabled

It seems like a lot of work to paper over all the libtest API we use to keep the stable guarantee... what other changes is libtest undergoing? Are there going to be changes that will break the ability to provide the facade?

@idubrov
Copy link
Contributor

idubrov commented Nov 3, 2019

Yeah... I've been waiting for rust-lang/rust#50297 to happen, which would, hopefully, solve these woes.

@idubrov
Copy link
Contributor

idubrov commented Nov 3, 2019

I think, clippy runs on stable so maybe it doesn't need that feature set?

@cormacrelf
Copy link
Contributor Author

No, the clippy task is running on nightly.

@idubrov idubrov merged commit f889007 into commure:master Nov 4, 2019
@idubrov
Copy link
Contributor

idubrov commented Nov 4, 2019

Thanks for doing the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants