-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge WRF-PartMC PartMC specific development to PartMC #168
Merged
jcurtis2
merged 148 commits into
compdyn:master
from
jcurtis2:wrf_partmc_for_partmc_merge
Feb 23, 2024
Merged
Merge WRF-PartMC PartMC specific development to PartMC #168
jcurtis2
merged 148 commits into
compdyn:master
from
jcurtis2:wrf_partmc_for_partmc_merge
Feb 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e by primary parts and components
…ength MOSAIC codes
mwest1066
reviewed
Jan 16, 2024
jcurtis2
commented
Feb 23, 2024
mwest1066
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merges in many of the changes I've made for using PartMC with WRF.
Changes included:
aero_components
which is replacingn_orig_part
to reduce memory requirements. WRF-PartMC for example had 70+ sources which maden_orig_part
very large yet sparsely populated as most particles have few sources.aero_id
.PMC_USE_WRF
)Things to consider/address before merging:
particle_error
in MOSAIC.F90 to be WRF-PartMC only which avoids MOSAIC killing a run for a "bad" particle.aero_component
for per_particle coagulation.aero_component
in this case currently gives less information than the old method.