Fix windows export symbols #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| /// Gets the namespace or class (by stripping typedefs) for the name | ||
| /// passed as a parameter, and if the parent is not passed, | ||
| /// then global scope will be assumed. | ||
| TCppScope_t GetScope(const std::string &name, TCppScope_t parent = 0); | ||
| DllExport TCppScope_t GetScope(const std::string &name, TCppScope_t parent = 0); |
There was a problem hiding this comment.
warning: use nullptr [modernize-use-nullptr]
Suggested change
| DllExport TCppScope_t GetScope(const std::string &name, TCppScope_t parent = 0); | |
| DllExport TCppScope_t GetScope(const std::string &name, TCppScope_t parent = nullptr); |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 78.74% 78.74%
=======================================
Files 8 8
Lines 3091 3091
=======================================
Hits 2434 2434
Misses 657 657
|
alexander-penev
force-pushed
the
FixWindowsExportSymbols
branch
from
8c0e48b to
468031a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.