add Buffer pool support #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user should use compio_runtime::buffer_pool::{BufferPool, BorrowedBuffer}
instaed of using compio_driver buffer pool directly
Sherlock-Holo
force-pushed
the
buffer-pool
branch
5 times, most recently
from
2b112f3
to
ac2d63a
Compare
Sherlock-Holo
force-pushed
the
buffer-pool
branch
from
ac2d63a
to
ece142e
Compare
some distributions(like ubuntu 20.04) doesn't support io-uring buf-ring feature, enable it to implement buffer pool will fail to fix this problem, when user doesn't enable io-uring-buf-ring feature, io-uring will use fallback buffer pool like polling/iocp
a file behind async fd may failed because not support epoll
Berrysoft
reviewed
Jul 29, 2024
| @@ -42,6 +42,7 @@ socket2 = { workspace = true } | |||
| [target.'cfg(windows)'.dependencies] | |||
| aligned-array = "1.0.1" | |||
| once_cell = { workspace = true } | |||
| pin-project-lite = { workspace = true } | |||
There was a problem hiding this comment.
If all targets need pin-project-lite, just write it once in [dependencies]
| @@ -126,14 +145,14 @@ impl Driver { | |||
| match res { | |||
| Ok(_) => { | |||
| if self.inner.completion().is_empty() { | |||
| Err(io::ErrorKind::TimedOut.into()) | |||
| Err(ErrorKind::TimedOut.into()) | |||
There was a problem hiding this comment.
I prefer don't make these meaningless changes.
| polling = ["dep:polling", "dep:os_pipe"] | ||
|
|
||
| io-uring-sqe128 = [] | ||
| io-uring-cqe32 = [] | ||
| io-uring-socket = [] | ||
| io-uring-buf-ring = ["dep:io_uring_buf_ring", "dep:slab"] |
There was a problem hiding this comment.
Need to check in the fusion driver if this feature enabled.
| @@ -81,6 +81,7 @@ io-uring = [ | |||
| "compio-fs?/io-uring", | |||
| "compio-net?/io-uring", | |||
| ] | |||
| io-uring-buf-ring = ["compio-driver/io-uring-buf-ring"] | |||
There was a problem hiding this comment.
I prefer not adding this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.