Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver,poll,iour): use Arc::clone instead of try_clone #306

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

Berrysoft
Copy link
Member

Closes #305

Some other changes are made to make clippy happy.

@Berrysoft Berrysoft added bug Something isn't working driver: io-uring About the io-uring driver driver: polling About the polling driver package: driver Related to compio-driver labels Oct 20, 2024
@Berrysoft Berrysoft requested a review from George-Miao October 20, 2024 15:44
@Berrysoft Berrysoft self-assigned this Oct 20, 2024
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 464552d into compio-rs:master Oct 21, 2024
42 checks passed
@Berrysoft Berrysoft deleted the fix/notify-handle-create branch October 21, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working driver: io-uring About the io-uring driver driver: polling About the polling driver package: driver Related to compio-driver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify handles should not be created with try_clone
2 participants