task(ci): add sonar #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afflom
force-pushed
the
PSCE-262
branch
13 times, most recently
from
9531399 to
30fa3a9
Compare
This was referenced Nov 7, 2023
jpower432
reviewed
Nov 7, 2023
.github/workflows/codecov.yml
Outdated
| pull_request: | ||
| branches: | ||
| - main | ||
| types: [opened, synchronize, reopened] |
There was a problem hiding this comment.
I believe this line is redundant. These activity types are what are set by default. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request.
.github/workflows/codecov.yml
Outdated
| -Dsonar.organization=rh-psce | ||
| - name: SonarQube Quality Gate check | ||
| uses: sonarsource/sonarqube-quality-gate-action@master |
There was a problem hiding this comment.
Can we pin to a commit instead of the master branch?
.github/workflows/codecov.yml
Outdated
| name: coverage | ||
| - name: SonarCloud Scan | ||
| uses: SonarSource/sonarcloud-github-action@master |
There was a problem hiding this comment.
Can we pin to a commit instead of the master branch?
jpower432
approved these changes
Nov 8, 2023
I found a phrase with a period that I removed to verify functionality. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sonarcloud.io/summary/overall?id=rh-psce_trestle-bot