Skip to content

Commit

Permalink
1.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@jonathanong
jonathanong committed Mar 13, 2014
1 parent eac0f1b commit 2ddbd1e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions component.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
"repo": "component/textarea-caret-position",
"version": "1.0.0",
"description": "(x, y) coordinates of a textarea's caret",
"dependencies": {
},
"development": {
"component/assert": "*"
},
Expand Down

6 comments on commit 2ddbd1e

@jonathanong
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dandv seems pretty solid. there are some bugs, but they are all edge cases. 1.0.0 is fine since we're not going to be changing the public API - everything else would be bug fixes.

how does meteor package stuff?

@dandv
Copy link
Member

@dandv dandv commented on 2ddbd1e Mar 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomesauce! Here's a great writeup on making libraries compatible with AMD, Node, and Meteor. Feel free to have a go at it. I'll be looking into issue #6 and the bugs you've raised.

@dandv
Copy link
Member

@dandv dandv commented on 2ddbd1e Mar 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On changing the public API - to address #1, I was thinking of reusing the compute object at least, if not the faux div. Then a sort of recalculate: true parameter may be necessary in case the textarea had been restyled. What are your thoughts on that?

@jonathanong
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for #1, i don't think we should bother until someone hits a performance issue.

making it compatible with every platform sounds like a pain in the ass. if anything, we'll probably switch to ES6 module syntax and expect everyone else to be able to consume it. it's probably easier just to copy and paste for now.

@dandv
Copy link
Member

@dandv dandv commented on 2ddbd1e Mar 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just Meteor compatibility? The initial reason I started looking into caret coordinates plugins was to find a replacement for the one we were using in meteor-autocomplete. I know the code is short enough that it can be copy/pasted, but we expect to make some improvement for Firefox (and maybe IE) support, so it would be nice to link rather than embed.

@jonathanong
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i don't mind adding it, but i do eventually want to get rid of UMD stuff and just stick to ES6.

Please sign in to comment.