Bad main

[josh]

@pennyfx the recent changes in 0.2.3 have a regression in the bower.json main. main must only be a single JS file (you can have alternative css files, but its not relative here).

This bootstrap file is basically useless, since its repeated here.

https://github.com/components/CustomElements/blob/0.2.3/src/custom-elements.js#L366-L368

See the 0.2.1 tag

https://github.com/components/CustomElements/blob/v0.2.1/bower.json#L8
https://github.com/components/CustomElements/blob/v0.2.1/custom-elements.js#L6

[pennyfx]

I didn't know there was a restriction on the number of files in main:, but I skimmed through bower/bower#393 and now understand the reasoning.

Nice to see that there is an if check inside the library for scope, so it doesn't die when window.CustomElements isn't defined.

Looks good. r+

[josh]

Should we just axe src/bootstrap.js from the checkin and build process?

[pennyfx]

I'm taking care of that now and I'll re-tag it.

[josh]

Thanks!

[pennyfx]

I looked at the code closer and the window.CustomElements check still needs to happen. The first part of the polyfill is setting up the Observer and the scope that is passed in there is window.CustomElements. I didn't see any place where they ensure its defined before using it.

[pennyfx]

Yeah, polymers loader takes care if it here. https://github.com/Polymer/CustomElements/blob/master/custom-elements.js#L21.

I'll re-add bootstrap.js but make it part of the grunt:concat instead of main:.

[josh]

The first part of the polyfill is setting up the Observer and the scope that is passed in there

For MutationObservers? Confused.

I didn't need to do anything in https://github.com/components/CustomElements/blob/v0.2.1/custom-elements.js.

This CustomElements v0.2.1 is whats shipped in production on github right now.