Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seiralise NanoCPUs as string #696

Merged
merged 1 commit into from
Oct 14, 2024
Merged

seiralise NanoCPUs as string #696

merged 1 commit into from
Oct 14, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Oct 11, 2024

value without a decimal part will be rendered as integer, so need to also accept integer

fixes docker/compose#11903

this PR only adds case int: but I used this opportunity to extract type in a dedicated go file

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from glours and jhrotko October 11, 2024 17:06
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit fb8e04d into compose-spec:main Oct 14, 2024
8 checks passed
@ndeloof ndeloof deleted the NanoCPUs branch October 14, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker compose config outputs an invalid format for deploy.resources.limits.cpus
2 participants