fix(reset): Add cycle detector in reset.go #703

idsulik · 2024-10-26T07:08:59Z

Issue: docker/compose#12235
I added the cycle detector to reset.go.
Example yaml to reproduce the issue:

x-healthcheck: &healthcheck
  healthcheck:
    test: [ "CMD", "wget", "--quiet", "--spider", "--timeout=1", "http://localhost:9000/health/live" ]
    start_period: 20s
    start_interval: 1s
    interval: 30s
    timeout: 2s
    retries: 5


  egress-service:
    <<: *healthcheck

Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>

glours

LGTM, thanks @idsulik for the fix

idsulik requested a review from ndeloof as a code owner October 26, 2024 07:09

fix(reset): Add cycle detector in reset.go

4f48073

Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>

idsulik force-pushed the issue-12235 branch from 3bac93c to 4f48073 Compare October 26, 2024 07:10

fix reset.go

fae4c28

Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>

idsulik force-pushed the issue-12235 branch from 6a02604 to fae4c28 Compare October 26, 2024 07:23

glours approved these changes Oct 28, 2024

View reviewed changes

glours merged commit 222d93c into compose-spec:main Oct 28, 2024
8 checks passed

idsulik mentioned this pull request Oct 29, 2024

fix(reset): Add cycle detection fix for services that are prefixed with the name of a preceding service #704

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(reset): Add cycle detector in reset.go #703

fix(reset): Add cycle detector in reset.go #703

idsulik commented Oct 26, 2024

glours left a comment

fix(reset): Add cycle detector in reset.go #703

fix(reset): Add cycle detector in reset.go #703

Conversation

idsulik commented Oct 26, 2024

glours left a comment

Choose a reason for hiding this comment