New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reset): Add cycle detection fix #706

Merged

glours merged 1 commit into compose-spec:main from idsulik:issue-12235-3

Nov 1, 2024

Contributor

idsulik commented Oct 31, 2024

Here docker/compose#12247 (comment) the user found one more case when it fires while it shouldn't.

Decided to move the detector inside the alias condition, because that's the only place where the cycle can happen.
Added one more test


          fix(reset): Add cycle detection fix

173367f

Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>

idsulik requested a review from ndeloof as a code owner

October 31, 2024 05:50

idsulik mentioned this pull request

[BUG] cycle detected at path with anchors docker/compose#12247

Closed

Contributor Author

idsulik commented Nov 1, 2024

@glours hi! Check please, I think it's pretty important

glours approved these changes

View reviewed changes

glours merged commit b9d3b1d into compose-spec:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet