This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
message namespace no longer includes a "db" #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
once #255 is merged I'll rebase and update the etcd adaptor |
|
this is ready for review since #255 is deferred until later |
trinchan
reviewed
Feb 3, 2017
pkg/message/message.go
Outdated
| @@ -29,12 +29,15 @@ type Msg interface { | |||
| Namespace() string | |||
| } | |||
|
|
|||
| // Namespace aliases the string type | |||
| type Namespace string | |||
There was a problem hiding this comment.
We convert back and forth all internally... the interface exposes the namespace as a string so I don't think we're gaining anything with this alias.
there was no reason to have Namespace be two parts as every adaptor was just splitting and throwing away the first portion, then having to re-compute later, this cleans up the processing of Namespace a good bit throughout fixes #221
jipperinbham
force-pushed
the
221-better-ns
branch
from
c044169 to
704ba20
Compare
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's never a case where the "db" portion of the namespace was used downstream so this change removes the expectation of needing to "split" the namespace to obtain the table/collection name.
fixes #221