Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

fix growing allocation of pendingOffsets when no offsetManager is in use #436

Merged
merged 2 commits into from
Nov 13, 2017

Conversation

jipperinbham
Copy link
Contributor

fixes #434

@jipperinbham
Copy link
Contributor Author

for reference, before the fix:

(pprof) top --cum
284.31MB of 284.31MB total (  100%)
Showing top 10 nodes out of 11 (cum >= 13.50MB)
      flat  flat%   sum%        cum   cum%
         0     0%     0%   284.31MB   100%  runtime.goexit
  132.80MB 46.71% 46.71%   270.81MB 95.25%  github.com/compose/transporter/pipeline.(*Node).write

after the fix:

(pprof) top --cum
201.02MB of 201.02MB total (  100%)
Showing top 10 nodes out of 11 (cum >= 16.50MB)
      flat  flat%   sum%        cum   cum%
         0     0%     0%   201.02MB   100%  runtime.goexit
   47.50MB 23.63% 23.63%   184.51MB 91.79%  github.com/compose/transporter/pipeline.(*Node).write

@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

Merging #436 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
- Coverage   84.17%   84.03%   -0.14%     
==========================================
  Files          61       61              
  Lines        4182     4184       +2     
==========================================
- Hits         3520     3516       -4     
- Misses        492      496       +4     
- Partials      170      172       +2
Impacted Files Coverage Δ
pipeline/node.go 86.03% <100%> (+0.06%) ⬆️
adaptor/postgres/tailer.go 78.21% <0%> (-2.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612eda1...a9895ea. Read the comment docs.

@jipperinbham jipperinbham merged commit 61a4566 into master Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.5.0 version seems to leak memory syncing between mongo 2.7 and 3.2.11
2 participants