Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support larger MAJOR version numbers #149

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Support larger MAJOR version numbers #149

merged 3 commits into from
Aug 30, 2023

Commits on Feb 1, 2023

  1. Support larger MAJOR version numbers 

    - We prefer to use CalVer + SemVer (YYYYMMDD as MAJOR) for versioning.
- Other software, like `npm`, supports this: https://github.com/npm/node-semver/blob/bdda212f4f6126a1b8821dc0731a17fdc2fc533f/classes/semver.js#L48
- Composer breaks with an invalid version string:

root@0c6964ad69d6:/var/project# COMPOSER_ROOT_VERSION=20230131.0.0 composer install

  [UnexpectedValueException]
  Invalid version string "20230131.0.0"
    @onethumb
    onethumb committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    2e6e152 View commit details
    Browse the repository at this point in the history

  2. Reduce repetition count to a saner level to retry CI

    @Seldaek
    Seldaek committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    249b023 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Add new formats without breaking any existing ones

    @Seldaek
    Seldaek committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    c42e6c2 View commit details
    Browse the repository at this point in the history