-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[N-09] Naming issues #433
[N-09] Naming issues #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab 🔪
Agree with you Scott that |
Seems like the only change with clear value is I'll rebase and drop the |
c41216d
to
4029d83
Compare
Some naming suggestions from OZ, if we choose to accept them
UInt
s withUint
TransparentUpgradeableConfiguratorProxy
toConfiguratorProxy
rescale
anddescale
variables with a sharedDESCALE
constantI did not take their suggestion re: CometProxyAdmin. Personally, I disagree with their reasoning. To me, the name
CometProxyAdmin
means that it is Comet's ProxyAdmin, not that it is solely the Admin of the CometProxy.